This repository was archived by the owner on Mar 17, 2021. It is now read-only.
fix(index): set default fallback to file-loader
#141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the update to v1.1.0 removed the default `fallback` to `file-loader`. This adds it again.
|
|
Member
|
@kaisermann we already do here https://github.com/webpack-contrib/url-loader/blob/master/src/utils/normalizeFallback.js#L38, what is problem you have? |
michael-ciniawsky
changed the title
file-loader
Member
|
Yep, I think this should be working already @kaisermann please elaborate what exactly didn't work for you :) #139 ? |
Author
|
I saw the issue was fixed right after I made the PR 😀. In anyway, I think the fix was not published to npm yet (last version is
|
Member
|
kk I see, no sry we still discussing this to some point but trying to release a fix asap :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the update to v1.1.0 removed the default
fallbacktofile-loader. This adds it again.This PR contains a:
Motivation / Use-Case
It's documented that the default
fallbackisfile-loader.Breaking Changes
Additional Info